Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-9144 ConnectedFilter: allow specifying extra fields to query #129

Merged
merged 5 commits into from
Dec 10, 2021
Merged

PXP-9144 ConnectedFilter: allow specifying extra fields to query #129

merged 5 commits into from
Dec 10, 2021

Conversation

paulineribeyre
Copy link
Contributor

Jira Ticket: PXP-9144

Improvements

  • ConnectedFilter: allow specifying extra fields to query aggregated data for

@paulineribeyre paulineribeyre mentioned this pull request Dec 9, 2021
Merged
mfshao
mfshao previously approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! please update the version number in package.json so you can make an npm release later

@paulineribeyre paulineribeyre requested a review from mfshao December 9, 2021 23:04
@mfshao
Copy link
Contributor

mfshao commented Dec 9, 2021

could you do a npm i and commit the lock as well?

@paulineribeyre
Copy link
Contributor Author

woops! sure

@mfshao
Copy link
Contributor

mfshao commented Dec 9, 2021

hmmm do you still have npm@6 locally? npm 6->7 has introduced a new peer dependency resolution logic so their lock files are in different format

could you npm i -g npm@7 and then regenerate the lock? sorry about these hassles 😅

@paulineribeyre
Copy link
Contributor Author

thank you @mfshao, sorry about that - fixed

@paulineribeyre paulineribeyre merged commit b10c23d into master Dec 10, 2021
@paulineribeyre paulineribeyre deleted the feat/extraAggsFields branch December 10, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
test-guppy-guppyTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @mfshao