Chore/python3 #220
Chore/python3 #220
Conversation
paulineribeyre
force-pushed
the
chore/python3
branch
2 times, most recently
from
656c1de to
f9ecc5f
Compare
paulineribeyre
force-pushed
the
chore/python3
branch
from
f9ecc5f to
6568b42
Compare
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
|
LGTM :D, try removing that python path in the uwsgi.ini, and someone else should look at the Dockerfile and |
|
Also we should look into what codacy is yelling about |
I can fix some of the issues, but codacy is complaining about a lot of things and i think most (all?) of them are unrelated to this PR, they just show up because |
|
One off-topic comment: could you please specify a bit more about how this PR will impact the deployment in the "Deployment changes" section in the PR description? You can remove that section if this PR requires no special head-ups from DevOps during deployment. :gratitude: |
indexd/alias/blueprint.py
Outdated
| hashes = flask.request.args.getlist('hash') | ||
| hashes = {h:v for h,v in map(lambda x: x.split(':', 1), hashes)} | ||
| hashes = flask.request.args.getlist("hash") | ||
| hashes = {h: v for h, v in [x.split(":", 1) for x in hashes]} |
There was a problem hiding this comment.
(trivial) replacing [] with () might be slightly more efficient
indexd/alias/drivers/alchemy.py
Outdated
| Initialize the SQLAlchemy database driver. | ||
| ''' | ||
| """ | ||
| super(SQLAlchemyAliasDriver, self).__init__(conn, **config) |
There was a problem hiding this comment.
(trivial) could be simply super().__init__...
indexd/index/blueprint.py
Outdated
| hashes = flask.request.args.getlist('hash') | ||
| hashes = {h: v for h, v in map(lambda x: x.split(':', 1), hashes)} | ||
| hashes = flask.request.args.getlist("hash") | ||
| hashes = {h: v for h, v in [x.split(":", 1) for x in hashes]} |
Breaking Changes
Dependency updates