Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/prefix #255

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Doc/prefix #255

merged 2 commits into from
Nov 26, 2019

Conversation

paulineribeyre
Copy link
Contributor

Rename test_settings.py to default_test_settings.py so that pytest doesn't think it's a test file.

Add optional settings parameter to get_app() to allow the tests to use a different config than the default one

Improvements

  • Clarify what PREPEND_PREFIX and ADD_PREFIX_ALIAS configurations do and improve their unit tests

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

em-ingram
em-ingram approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@em-ingram em-ingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulineribeyre paulineribeyre merged commit 8313c86 into master Nov 26, 2019
@paulineribeyre paulineribeyre deleted the doc/prefix branch November 26, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em-ingram em-ingram em-ingram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @em-ingram