Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrate) #256

Merged
merged 1 commit into from
Dec 10, 2019
Merged

fix(migrate) #256

merged 1 commit into from
Dec 10, 2019

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Dec 10, 2019 •
edited
Loading

New Features

  • Add option to enable/disable the use of arborist tags in ACL->authz migration script (disabled by default)

Bug Fixes

  • Fix bug in ACL->authz migration script that removed non-word characters from ACL elements

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre requested a review from vpsx December 10, 2019 19:19
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2019

This pull request introduces 1 alert when merging 3e14d67 into d3c3d3e - view on LGTM.com

new alerts:

  • 1 for Unused import

frickjack
frickjack approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@frickjack frickjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for brain commons BEAT-PD update - thanks a lot, Pauline!
https://data.braincommons.org/index/index?acl=BEAT-PD

bin/migrate_acl_authz.py
dest="use_tags",
help="Whether to use arborist tags. If set to False, the resource paths will be used",
default=False,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

bin/migrate_acl_authz.py
acl_item = re.sub(r"\W+", "", acl_item)
# Pauline 2019-12-10 Disabling this, causes a bug when removing "-"
# if acl_item != "*":
# acl_item = re.sub(r"\W+", "", acl_item)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@paulineribeyre paulineribeyre merged commit fd45762 into master Dec 10, 2019
@paulineribeyre paulineribeyre deleted the fix/migrate branch December 10, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frickjack frickjack frickjack approved these changes

@vpsx vpsx Awaiting requested review from vpsx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @frickjack