Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drs endpoints #261

Merged
merged 18 commits into from
Mar 17, 2020
Merged

Drs endpoints #261

merged 18 commits into from
Mar 17, 2020

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Feb 27, 2020 •
edited by paulineribeyre
Loading

Description about what this pull request does.

Please make sure to follow the DEV guidelines before asking for review.

New Features

@github-actions
Copy link

github-actions bot commented Feb 27, 2020 •
edited
Loading

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre self-requested a review February 27, 2020 19:56
@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 11 alerts when merging 694c4c3 into 330598d - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 11 alerts when merging 818d5f8 into 330598d - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 1 for Unreachable code

paulineribeyre
paulineribeyre reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't looked at the tests yet

indexd/drs/blueprint.py Show resolved Hide resolved
indexd/default_settings.py Outdated Show resolved Hide resolved
indexd/app.py Outdated Show resolved Hide resolved
indexd/default_settings.py Outdated Show resolved Hide resolved
indexd/drs/errors.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/fence_client.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2020

This pull request introduces 4 alerts when merging 77265f0 into 330598d - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2020

This pull request introduces 4 alerts when merging e4185a9 into 330598d - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2020

This pull request introduces 4 alerts when merging 4cab3f8 into 330598d - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 11, 2020

This pull request introduces 4 alerts when merging 6b4e17f into c300438 - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2020

This pull request introduces 4 alerts when merging c687252 into c300438 - view on LGTM.com

new alerts:

  • 4 for Unused import

paulineribeyre
paulineribeyre reviewed Mar 13, 2020
View reviewed changes
indexd/app.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/fence_client.py Outdated Show resolved Hide resolved
indexd/fence_client.py Outdated Show resolved Hide resolved
indexd/fence_client.py Outdated Show resolved Hide resolved
openapis/swagger.yaml Outdated Show resolved Hide resolved
openapis/swagger.yaml Outdated Show resolved Hide resolved
openapis/swagger.yaml Outdated Show resolved Hide resolved
openapis/swagger.yaml Outdated Show resolved Hide resolved
openapis/swagger.yaml Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2020

This pull request introduces 5 alerts when merging 8401cd3 into c300438 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Duplicate key in dict literal

paulineribeyre
paulineribeyre reviewed Mar 17, 2020
View reviewed changes
tests/test_drs.py Outdated Show resolved Hide resolved
tests/test_drs.py Show resolved Hide resolved
@BinamB BinamB marked this pull request as ready for review March 17, 2020 19:02
@BinamB BinamB merged commit db40aec into master Mar 17, 2020
@paulineribeyre paulineribeyre deleted the drs-endpoints branch March 17, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BinamB @paulineribeyre