Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): keep existing behavior for start did, only order wit… #262

Merged
merged 2 commits into from
Mar 9, 2020
Merged

fix(pagination): keep existing behavior for start did, only order wit… #262

merged 2 commits into from
Mar 9, 2020

Conversation

Avantol13
Copy link
Contributor

…h new pagination

New Features

Breaking Changes

Bug Fixes

  • keep existing behavior when using pagination using start did (instead of new page param), ordering by date causes issues with previous behavior, now only order by date when using new page param

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

github-actions bot commented Mar 9, 2020 •
edited
Loading

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@Avantol13 Avantol13 merged commit 95a84d4 into master Mar 9, 2020
@Avantol13 Avantol13 deleted the fix/order-start branch March 9, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avantol13 @paulineribeyre