Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend prefix to new versions #274

Merged
merged 3 commits into from
May 20, 2020
Merged

Prepend prefix to new versions #274

merged 3 commits into from
May 20, 2020

Conversation

paulineribeyre
Copy link
Contributor

because of the unpinned authutils, version “5.0.0b1" was being installed, which tried to install cdiserrors version "1.0.0b1" and errored

Improvements

  • Prepend the configured prefix to new versions' GUIDs, unless a GUID has been provided by the user

Dependency updates

  • Pin authutils==4.0.0 in setup.py

@paulineribeyre paulineribeyre changed the title Fix/version prefix Prepend prefix to new versions May 19, 2020
@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

em-ingram
em-ingram approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@em-ingram em-ingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the authutils fix!

@paulineribeyre paulineribeyre merged commit fd6d959 into master May 20, 2020
@paulineribeyre paulineribeyre deleted the fix/version-prefix branch May 20, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em-ingram em-ingram em-ingram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @em-ingram