Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-6604) DRS endpoint to resolve regardless of prefix #291

Merged
merged 13 commits into from
Oct 20, 2020

Conversation

olivarity
Copy link
Contributor

@olivarity olivarity commented Oct 1, 2020

Jira Ticket: PXP-6604

Now when attempting to GET a record for a specified GUID, the following resolution steps will be taken:

  1. Start by trying to resolve the provided ID
  2. If unsuccessful, check what the DEFAULT_PREFIX Indexd config is set to
  3. If the ID starts with the prefix, attempt to remove the prefix from the provided ID and try resolving again
  4. If the ID does not start with the prefix, attempt to add the prefix to the provided ID and try resolving again

New Features

  • Added new get_with_nonstrict_prefix helper to index_driver.
  • Updated /ga4gh/drs/v1/objects/<path:object_id> and /index/<path:object_id> GET endpoints to utilize this new method.

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre
Copy link
Contributor

could you move the non-bullet points part of the PR description to before "New Features"? 🙏 our script that parses PR descriptions to generate release notes interprets each new line as a "new feature"

indexd/index/blueprint.py Show resolved Hide resolved
indexd/index/drivers/alchemy.py Outdated Show resolved Hide resolved
indexd/index/drivers/alchemy.py Outdated Show resolved Hide resolved
@olivarity olivarity marked this pull request as ready for review October 12, 2020 19:39
@olivarity olivarity changed the title WIP: (PXP-6604) DRS endpoint to resolve regardless of prefix (PXP-6604) DRS endpoint to resolve regardless of prefix Oct 12, 2020
indexd/index/blueprint.py Show resolved Hide resolved
tests/test_driver_alchemy_crud.py Outdated Show resolved Hide resolved
tests/test_driver_alchemy_crud.py Outdated Show resolved Hide resolved
indexd/index/drivers/alchemy.py Show resolved Hide resolved
@olivarity olivarity merged commit a74f12c into master Oct 20, 2020
@paulineribeyre paulineribeyre deleted the fix/drs-resolve-no-prefix branch November 11, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants