-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PXP-6604) DRS endpoint to resolve regardless of prefix #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
olivarity
commented
Oct 1, 2020
could you move the non-bullet points part of the PR description to before "New Features"? 🙏 our script that parses PR descriptions to generate release notes interprets each new line as a "new feature" |
olivarity
changed the title
WIP: (PXP-6604) DRS endpoint to resolve regardless of prefix
(PXP-6604) DRS endpoint to resolve regardless of prefix
Oct 12, 2020
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
paulineribeyre
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-6604
Now when attempting to GET a record for a specified GUID, the following resolution steps will be taken:
DEFAULT_PREFIX
Indexd config is set toNew Features
get_with_nonstrict_prefix
helper toindex_driver
./ga4gh/drs/v1/objects/<path:object_id>
and/index/<path:object_id>
GET endpoints to utilize this new method.