fix(updated): actually update updated_date when modifying record #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
| @@ -878,6 +878,8 @@ def update_blank_record(self, did, rev, size, hashes, urls, authz=None): | |||
|
|
|||
| record.rev = str(uuid.uuid4())[:8] | |||
|
|
|||
| record.updated_date = datetime.datetime.utcnow() | |||
There was a problem hiding this comment.
all other dates in indexd use .now() so if you want to use .utcnow() maybe we should change it everywhere? 😕
There was a problem hiding this comment.
oh nvm, i'm wrong, only unit tests use .now()
There was a problem hiding this comment.
that's what it uses when it creates the record in the db 😬 so I went based off that
There was a problem hiding this comment.
at least, it's the default
indexd/indexd/index/drivers/alchemy.py
Line 75 in 5002383
paulineribeyre
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes