Revert "Revert "fix(migrate): improve acl->authz migration, remove de… #338
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
| raise EnvironmentError( | ||
| "program or project {} does not exist".format(acl_item) |
There was a problem hiding this comment.
should we keep this at least as a warning log?
There was a problem hiding this comment.
the warning would end up needing to be more generic b/c now it's not just that program/proj don't exist, but that there's no mapping either. I think the error log in a few lines sorta covers that? https://github.com/uc-cdis/indexd/pull/338/files/24af7553837da98ddf5a53259b91e4f87d23a936#diff-02f08e0cd101b79f6a25f6d6689008de374d7b6399a2a1291ee52faafc73aacdR247
Lemme know if you disagree
There was a problem hiding this comment.
basically if nothing is found in any of the cases then there'll be an error log
There was a problem hiding this comment.
ah ok, yeah that other log works
|
i think we should add the changes to the PR description even if they have already been published in release notes |
|
Force merging even though a single test is failing. It is a known faulty test |
…precated endpoints (#336)" (#337)"
COPY of #336 with addition of fixing broken integration test. Had previously force merged, reverted, now fixing
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes