Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-6580): fix data submission by only writing acl and authz iff both are empty #330

Conversation

johnfrancismccann
Copy link
Contributor

@johnfrancismccann johnfrancismccann commented Sep 4, 2020

Bug Fixes

  • Only write acl and authz fields of corresponding Indexd record during data submission iff both fields are empty to begin with. Prevents authz field from being unintentionally populated in commons not using authz.

Breaking Changes

  • Note that this PR will cause Sheepdog behavior to change slightly during a data submission flow in which the acl and/or authz field are previously populated in the corresponding Indexd record and the Indexd uploader field is not null and the Sheepdog submitter does not match the Indexd uploader. While the existing behavior will cause data submission to fail and report an error message to the user, this PR’s changes will mean that data submission can still succeed in this case of populated acl/authz and uploader mismatch. I believe this change in behavior is not problematic in that it would be unexpected in any commons for uploader and (acl and/or authz) to both be populated.

@PlanXCyborg
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@Avantol13
Copy link
Contributor

can you add your "note" comment into the "Breaking Changes" section of the PR just so that it gets picked up / read by people reading the release notes when we create a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants