Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp to correct format #248

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Fix timestamp to correct format #248

merged 7 commits into from
Nov 27, 2023

Conversation

thanh-nguyen-dang
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang commented Nov 17, 2023

Jira Ticket: PXP-10748

ES7 does not allow tag with : we need to change it to -

Copy link

github-actions bot commented Nov 17, 2023

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

jawadqur
jawadqur previously approved these changes Nov 17, 2023
m0nhawk
m0nhawk previously approved these changes Nov 17, 2023
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

m0nhawk
m0nhawk previously approved these changes Nov 17, 2023
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawadqur
Copy link
Contributor

image

This is when we re-run ETL in helm, I confirm it works as intended now

@jawadqur jawadqur merged commit 8a09251 into master Nov 27, 2023
3 checks passed
@jawadqur jawadqur deleted the fix/timestamp branch November 27, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants