Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open files issue and bump firesim with various fixes #1258

Merged
merged 11 commits into from
Oct 19, 2022

Conversation

sagark
Copy link
Member

@sagark sagark commented Oct 17, 2022

Fix the open files limit issue automatically for systems that have a sufficient hard limit, but insufficient soft limit (e.g. all millennium machines).

Also, many fixes from firesim/firesim#1266

Related PRs / Issues:
N/A

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you mark the PR with a changelog: label?

@jerryz123
Copy link
Contributor

The plan is to merge this script now as a temporary thing, then by the next release, the top level setup script will be modified to also do everything this script currently does.

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the understanding that the first-setup-fast script will be merged into the build-setup script in future PRs

@sagark sagark merged commit 3bc56ac into main Oct 19, 2022
@sagark sagark deleted the fix-open-files-limit-and-fsim branch October 19, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants