Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Initial-Repo-Setup.rst to force conda-lock version #1490

Closed
wants to merge 1 commit into from
Closed

Update Initial-Repo-Setup.rst to force conda-lock version #1490

wants to merge 1 commit into from

Conversation

rohanku
Copy link

@rohanku rohanku commented May 29, 2023

Related PRs / Issues:

Fixes #1488

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see your issue with any conda-lock version greater than 0.*? We use the following for our environment which is a bit more flexible.

- conda-lock>=1
I would change it to that to make it more flexible.

@rohanku
Copy link
Author

rohanku commented May 30, 2023

I could do conda-lock=1, since conda-lock>=1 no longer works (version 2.0.0 is the one that is causing issues).

@abejgonzalez
Copy link
Contributor

abejgonzalez commented May 30, 2023

I could do conda-lock=1, since conda-lock>=1 no longer works (version 2.0.0 is the one that is causing issues).

Lets do that then (if you can also update the lockfiles by changing chipyard/conda-reqs/chipyard.yaml and running: https://github.com/ucb-bar/chipyard/blob/main/scripts/generate-conda-lockfiles.sh that would be great as well). Thanks.

@abejgonzalez
Copy link
Contributor

Update: I'll do this quickly in another PR (since this PR is from a fork).

@rohanku
Copy link
Author

rohanku commented May 31, 2023

Sorry I didn't get around to it, but that would be great. I don't actually have conda on my computer anymore since I decided to install the dependencies I needed manually.

@abejgonzalez abejgonzalez mentioned this pull request May 31, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda install -n base conda-lock no longer works with existing Lockfiles due to new conda-lock release
3 participants