Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FireMarshal #1502

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Bump FireMarshal #1502

merged 2 commits into from
Jun 8, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jun 7, 2023

Bump FireMarshal for various optimizations:

  • Faster Linux submodule initialization
  • Use pre-cached buildroot image

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor Author

abejgonzalez commented Jun 7, 2023

This makes build-setup.sh take roughly ~30m (25m39s) now. Previously on the same machine it took 51m6s.

@abejgonzalez abejgonzalez requested a review from jerryz123 June 8, 2023 05:25
@abejgonzalez abejgonzalez merged commit af31137 into main Jun 8, 2023
@jerryz123 jerryz123 deleted the fm-opts branch August 22, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants