Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (newly) expected name argument to PeripheryBus constructor. #185

Closed
wants to merge 2 commits into from
Closed

Add (newly) expected name argument to PeripheryBus constructor. #185

wants to merge 2 commits into from

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Dec 19, 2019

As of chipsalliance/rocket-chip#2229, the PeripheryBus() constructor has grown a new String parameter (without a default). Add it to the call in DmaSpec tests.

@ucbjrl ucbjrl requested a review from grebe December 19, 2019 17:50
@ucbjrl ucbjrl mentioned this pull request Feb 19, 2020
Open
@ucbjrl ucbjrl mentioned this pull request Mar 28, 2020
Merged
@chick chick mentioned this pull request Mar 29, 2020
Merged
chick
chick approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've talked to @grebe about this and he said he thought just giving it a name was fine.

@ucbjrl
Copy link
Contributor Author

ucbjrl commented Mar 29, 2020

Superseded by #203

@ucbjrl ucbjrl closed this Mar 29, 2020
@ucbjrl ucbjrl deleted the fixPeripheryBusname branch March 29, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

@grebe grebe Awaiting requested review from grebe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ucbjrl @chick