Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable output paths for Otter Generate #402

Merged
merged 27 commits into from
Sep 20, 2021

Conversation

chrispyles
Copy link
Member

As titled. Also includes an update to Otter Assign which changes the name of the generated autograder zip file to {notebook stem}-autograder_{timestamp}.zip.

Closes #401

@chrispyles chrispyles added the enhancement New feature or request label Sep 15, 2021
@chrispyles chrispyles added this to the v3.1.4 milestone Sep 15, 2021
@chrispyles chrispyles modified the milestones: v3.1.4, v3.2.0 Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #402 (e502ce5) into master (a5f3608) will increase coverage by 0.03%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   79.49%   79.52%   +0.03%     
==========================================
  Files          90       90              
  Lines        5057     5060       +3     
==========================================
+ Hits         4020     4024       +4     
+ Misses       1037     1036       -1     
Impacted Files Coverage Δ
otter/assign/v0/utils.py 77.86% <ø> (ø)
test/test_generate/test_autograder.py 100.00% <ø> (ø)
test/test_grade.py 100.00% <ø> (ø)
otter/generate/__init__.py 83.33% <83.33%> (+0.50%) ⬆️
otter/assign/utils.py 68.38% <100.00%> (+0.83%) ⬆️
test/__init__.py 90.00% <100.00%> (+0.34%) ⬆️
test/test_assign.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f3608...e502ce5. Read the comment docs.

@chrispyles
Copy link
Member Author

@fritterhoff it looks like builds on this branch have started failing due to something related to buildkit. Do you have any idea what's going on here? https://github.com/ucbds-infra/otter-grader/runs/3642222139#step:5:168

@chrispyles
Copy link
Member Author

Update on the build issues: this seems to be a known issue with the GHA cache for buildx. docker/buildx#681

@chrispyles chrispyles merged commit 75c3bc0 into ucbds-infra:master Sep 20, 2021
@chrispyles chrispyles deleted the fix-401 branch September 20, 2021 03:43
@champoll
Copy link

champoll commented Oct 6, 2021

Just to clarify, how do I use this? When I run "otter assign" on my notebook, the output still contains a file named autograder.zip

@fritterhoff
Copy link
Contributor

Update on the build issues: this seems to be a known issue with the GHA cache for buildx. docker/buildx#681

Ah sorry ... I missed the notification. Sorry that I did not react.

@chrispyles
Copy link
Member Author

@champoll This fix is part of v3.2.0, which has not yet been released. If you want to use it, you will need to install the development version of Otter from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom names for autograder.zip files
3 participants