Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreate Data Representation interactive for Field Guide #1183

Merged
merged 17 commits into from
Nov 5, 2019
Merged

Recreate Data Representation interactive for Field Guide #1183

merged 17 commits into from
Nov 5, 2019

Conversation

eAlasdair
Copy link
Contributor

@eAlasdair eAlasdair commented Oct 30, 2019 •
edited
Loading

Relates to #1182

Changes

  • Rebuild interactive for our system
  • Implement in context
  • Licence appropriately
  • Add documentation

Decisions

Interactive is for a chapter that doesn't exist yet, so the 'context' it is implemented in is only the 'all interactives' section of the Interactives page

@eAlasdair eAlasdair self-assigned this Oct 30, 2019
@eAlasdair eAlasdair marked this pull request as ready for review November 1, 2019 00:03
@eAlasdair eAlasdair requested a review from courtneycb November 1, 2019 00:03
courtneycb
courtneycb suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@courtneycb courtneycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🐨 🏆

courtneycb
courtneycb suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@courtneycb courtneycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions, nice work :)

@eAlasdair eAlasdair merged commit 5926ea2 into develop Nov 5, 2019
@eAlasdair eAlasdair deleted the issue/1182/datarep branch November 5, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneycb courtneycb courtneycb approved these changes

Assignees

@eAlasdair eAlasdair

Labels
interactives
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eAlasdair @courtneycb