Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix export2text.m #124

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Bugfix export2text.m #124

merged 1 commit into from
Apr 29, 2020

Conversation

maffotto
Copy link
Contributor

@maffotto maffotto commented Feb 2, 2020

Fix for errors in export when colon character is present in the Binlabel

@andrewxstewart
Copy link
Member

Hi Maffotto,

Thanks for the bugfix suggestion and pull request.

I think there may be reasons that a colon is a forbidden character in a binlabel. What has your experience been?

@maffotto
Copy link
Contributor Author

Hi Andrew,

I don't think that the colon is a forbidden character in a binlabel, because I was able to use labels like Face: Male and Face: Female for Bins creation.

I had a problem when I tried to export the bin data, and I've found that the function does not recognize the : as a forbidden character to replace with _, so it tries to create a filename with a colon inside (in my case Face: Male.txt) which is not allowed on Windows.

That's why I suggested this fix.

Cheers,
Antonio

@andrewxstewart
Copy link
Member

Ah, I see. Ok.

Thanks for the fix.

@andrewxstewart andrewxstewart merged commit 0977f6f into ucdavis:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants