Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in breakToText #1590

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Bugs in breakToText #1590

merged 1 commit into from
Oct 20, 2020

Conversation

vutoan1245
Copy link
Contributor

Fixes #1482, #1483

@vutoan1245 vutoan1245 added the feels broken Issues that aren't major but make the platform seem broken or janky and leave a bad user perception label Oct 12, 2020
jpeterson976
jpeterson976 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works great for both headings and figures with my testing.

zachberry
zachberry approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM

@zachberry zachberry merged commit e8af75b into ucfopen:dev/15-magnetite Oct 20, 2020
@zachberry zachberry added this to the 15 - Magnetite milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeterson976 jpeterson976 jpeterson976 approved these changes

@zachberry zachberry zachberry approved these changes

Assignees
No one assigned
Labels
feels broken Issues that aren't major but make the platform seem broken or janky and leave a bad user perception
Projects
None yet
Milestone
15 - Magnetite
Development

Successfully merging this pull request may close these issues.
3 participants
@vutoan1245 @zachberry @jpeterson976