Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights newly created module #1630

Conversation

jpeterson976
Copy link
Contributor

Fixes #1510

Grabs the draftId of the newly created module and highlights it in the dashboard.

@jpeterson976 jpeterson976 requested a review from a team December 14, 2020 18:59
ctcuff
ctcuff previously approved these changes Dec 17, 2020
Copy link
Contributor

@ctcuff ctcuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor CSS issue but looks good! Tested in Chrome, FF, and Safari.

@@ -37,6 +37,11 @@
background-color: $color-banner-bg;
}

&.is-new {
background-color: lighten($color-action-minor, 15%);
font-weight: bold;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like setting the font-weight here also affects the font-weight of the buttons in the module's menu

Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Marking as 'request changes' based on what @ctcuff found - but once that css issue is resolved I'll approve

Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I merged in dev/16)

LGTM!

@zachberry zachberry merged commit 8f1e767 into ucfopen:dev/16-connemara-marble Jan 21, 2021
@zachberry zachberry added this to the 16 - Connemara Marble milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants