-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlights newly created module #1630
Highlights newly created module #1630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor CSS issue but looks good! Tested in Chrome, FF, and Safari.
@@ -37,6 +37,11 @@ | |||
background-color: $color-banner-bg; | |||
} | |||
|
|||
&.is-new { | |||
background-color: lighten($color-action-minor, 15%); | |||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like setting the font-weight here also affects the font-weight of the buttons in the module's menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Marking as 'request changes' based on what @ctcuff found - but once that css issue is resolved I'll approve
…issue/1510-highlight-new-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I merged in dev/16)
LGTM!
Fixes #1510
Grabs the draftId of the newly created module and highlights it in the dashboard.