Clear selection on page change #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maufcost
previously approved these changes
Dec 17, 2020
zachberry
requested changes
Dec 18, 2020
There was a problem hiding this comment.
This clears the selection when using the top and bottom buttons but doesn't when using the left-hand nav menu. Also I'm weary of doing any DOM manipulation in the *-util classes (not that we're perfect about that).
Instead, I'm thinking add something to viewer-app's componentDidUpdate method. There's a method that gets called there - scrollToTopIfNavTargetChanging - We could add a similar method where that gets called - clearSelectionIfNavTargetChanging. (Or combine both into scrollToTopAndClearSelectionIfNavTargetChanging, but nobody seems to like my super-long function names)
…Obojobo into issue/1618-clear-selection-on-page-change
…issue/1618-clear-selection-on-page-change
zachberry
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any text highlighted on a page now gets cleared when navigating to different pages using the nav button at the top/bottom of modules. For this issue, I've added a
clearSelection()function to thenav-utilbut I'm open to moving it to a different file if appropriate.Fixes #1618