materia - custom launch vars and temporary context_id update #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachberry
requested changes
Mar 18, 2021
There was a problem hiding this comment.
Had a question on resource_link_id and recommending a minor change to rename materiaChunkId to materiaOboNodeId, as we're using the term OboNode more often than chunk. However chunk is more descriptive (as it's a "leaf" OboNode) so you know - I'm okay if we leave it as is.
packages/obonode/obojobo-chunks-materia/server/route-helpers.js
Outdated
Show resolved
Hide resolved
packages/obonode/obojobo-chunks-materia/server/route-helpers.js
Outdated
Show resolved
Hide resolved
packages/obonode/obojobo-chunks-materia/server/route-helpers.js
Outdated
Show resolved
Hide resolved
packages/obonode/obojobo-chunks-materia/server/route-helpers.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachary Berry <zachberry@gmail.com>
Co-authored-by: Zachary Berry <zachberry@gmail.com>
Co-authored-by: Zachary Berry <zachberry@gmail.com>
zachberry
requested changes
Mar 18, 2021
packages/obonode/obojobo-chunks-materia/server/route-helpers.js
Outdated
Show resolved
Hide resolved
zachberry
approved these changes
Mar 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes materia launch params to better encapsulate score/attempt windows
adds a bunch of documentation to the lti launch params for materia