Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds input validation for the Materia settings dialog #1732

Conversation

zachberry
Copy link
Member

Fixes #1730 , Depends on #1715

Fixes some graphic issues with RevealableContainer, adds tests
…where setting the height of a Materia chunk impacted the display of the editor
@zachberry zachberry added this to the 18 - Opal milestone Mar 19, 2021
iturgeon
iturgeon previously approved these changes Mar 22, 2021
Copy link
Member

@iturgeon iturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions / minor comments, but looks good to go so far

zachberry and others added 4 commits March 22, 2021 16:37
Co-authored-by: Ian Turgeon <iturgeon@hey.com>
Co-authored-by: Ian Turgeon <iturgeon@hey.com>
Co-authored-by: Ian Turgeon <iturgeon@hey.com>
Co-authored-by: Ian Turgeon <iturgeon@hey.com>
@zachberry zachberry merged commit 5b44344 into ucfopen:dev/18-opal Mar 22, 2021
@zachberry zachberry deleted the issue/1730-input-validation-for-materia-dialog branch March 22, 2021 20:50
@iturgeon iturgeon mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants