-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure caption width in tutorial #1766
Figure caption width in tutorial #1766
Conversation
@jpeterson976 @iturgeon Both good points. Here's my thought - what if we stick with this change - |
Actually, it doesn't have any effect for size = medium either, since medium images already are at text width. So perhaps we disable the input for large and medium sizes. |
* Forces caption width to image-width when size is large or medium
Works great in the editor with my testing. Code looks good too, found some stuff I missed in the original PR. Only change I can think of is the new tutorial section should probably be updated to mention the caption width option is only available for small and custom sizes. |
…'t work for large and medium images
Fixes #1762
I may have added a little too much to the new tutorial section, so let me know if I should cut it back at all.
I also changed
max-width
totext-width
since that's a little more accurate, and made a minor CSS change for text width captions to better account for medium and large sizes.