-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-select modules in the Dashboard #1824
Multi-select modules in the Dashboard #1824
Conversation
That is a great start, @jpeterson976 :) The design looks pretty good to me. There is just one thing I'd like to say though: I believe leaving those checkboxes with their full opacity at all times kind of clutters the dashboard. We could make them appear on hover. I tweaked the code a bit and got this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super awesome!
I haven't reviewed the code yet, but here changes I'm thinking:
- Allow users to hit ESC to cancel out multi-select mode
- I'm thinking initially only show the checkbox when the module edit menu is open rather than on hover
- Once multi-select is enabled, no longer show the module edit menu
- I'm wondering if we need a more annoying confirmation when deleting modules - as in, they are asked to type DELETE to confirm they want to delete multiple modules at once. If we don't, then I think the warning prompt should be more serious, like "Are you sure you want to DELETE these N modules? This action can't be undone!"
- You replicated the mock up perfectly, but seeing it in action I'm worried the Delete and (X) buttons are too hard to notice. Here's a mockup of what I'm thinking - I don't like the look of this as much but the change to this purple background which matches the multi-select background of selected modules is a more noticeable change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nailed it. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good! Can't wait to see it in production. Tested by deleting a couple modules all at once and typing variations of "DELETE" (e.g. "Delete", "delete", etc). Everything works as expected, and as always, great job!
What bulk actions will be available with this feature? Will users be able to bulk download or clone? I need to clone 50+ modules for a faculty member this term and that option would be really helpful. I suppose a bulk share would be vital, too. |
Not yet, but it's coming. This feature will let you bulk delete, and then we'll add in other bulk features in another update. |
Resolves #1790
No longer WIP - lets users select and delete multiple modules at once. Sharing/downloading will be added on with future issues.
Todos: