Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select modules in the Dashboard #1824

Conversation

jpeterson976
Copy link
Contributor

@jpeterson976 jpeterson976 commented May 17, 2021

Resolves #1790

No longer WIP - lets users select and delete multiple modules at once. Sharing/downloading will be added on with future issues.

Todos:

  • Dashboard UI for multi-select mode
  • Modify redux actions for selecting/deselecting multiple modules
  • Add new action for bulk deletions
  • Have UI actually do things
  • Jest stuff

@maufcost
Copy link
Contributor

maufcost commented May 18, 2021

That is a great start, @jpeterson976 :) The design looks pretty good to me. There is just one thing I'd like to say though: I believe leaving those checkboxes with their full opacity at all times kind of clutters the dashboard. We could make them appear on hover. I tweaked the code a bit and got this:

obo

@jpeterson976 jpeterson976 marked this pull request as ready for review May 24, 2021 19:18
@jpeterson976 jpeterson976 requested review from a team, zachberry and sergioncp and removed request for a team May 24, 2021 19:21
@jpeterson976 jpeterson976 requested a review from a team May 26, 2021 15:36
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super awesome!

I haven't reviewed the code yet, but here changes I'm thinking:

  1. Allow users to hit ESC to cancel out multi-select mode
  2. I'm thinking initially only show the checkbox when the module edit menu is open rather than on hover
  3. Once multi-select is enabled, no longer show the module edit menu
  4. I'm wondering if we need a more annoying confirmation when deleting modules - as in, they are asked to type DELETE to confirm they want to delete multiple modules at once. If we don't, then I think the warning prompt should be more serious, like "Are you sure you want to DELETE these N modules? This action can't be undone!"
  5. You replicated the mock up perfectly, but seeing it in action I'm worried the Delete and (X) buttons are too hard to notice. Here's a mockup of what I'm thinking - I don't like the look of this as much but the change to this purple background which matches the multi-select background of selected modules is a more noticeable change:

image

@zachberry zachberry changed the base branch from dev/21-beryl to dev/22-aquamarine June 3, 2021 20:10
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it. LGTM!

Copy link
Contributor

@maufcost maufcost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! Can't wait to see it in production. Tested by deleting a couple modules all at once and typing variations of "DELETE" (e.g. "Delete", "delete", etc). Everything works as expected, and as always, great job!

@paradisojr
Copy link

paradisojr commented Jun 7, 2021

What bulk actions will be available with this feature? Will users be able to bulk download or clone? I need to clone 50+ modules for a faculty member this term and that option would be really helpful. I suppose a bulk share would be vital, too.

@zachberry
Copy link
Member

What bulk actions will be available with this feature? Will users be able to bulk download or clone? I need to clone 50+ modules for a faculty member this term and that option would be really helpful. I suppose a bulk share would be vital, too.

Not yet, but it's coming. This feature will let you bulk delete, and then we'll add in other bulk features in another update.

@zachberry zachberry merged commit 9987b58 into ucfopen:dev/22-aquamarine Jun 7, 2021
@zachberry zachberry added this to the 22 - Aquamarine milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants