Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken select on Safari #1904

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fixed broken select on Safari #1904

merged 1 commit into from
Oct 6, 2021

Conversation

maufcost
Copy link
Contributor

@maufcost maufcost commented Sep 3, 2021

Fixes #1902

@maufcost
Copy link
Contributor Author

maufcost commented Sep 3, 2021

It turns out the select element didn't have any @mixins applied to it. Safari was being stubborn about rendering it with its appearance set to none. It should look better now. Tested on Chrome, Safari, and Mozilla.

jpeterson976
jpeterson976 previously approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested with the same browsers, select box looks good in all of them!

FrenjaminBanklin
FrenjaminBanklin previously approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in all three browsers, issue seems to be resolved.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/25-bixbite to dev/26-neon-apatite September 14, 2021 14:50
@FrenjaminBanklin FrenjaminBanklin dismissed stale reviews from jpeterson976 and themself September 14, 2021 14:50

The base branch was changed.

@FrenjaminBanklin FrenjaminBanklin merged commit 8acf79c into ucfopen:dev/26-neon-apatite Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

@jpeterson976 jpeterson976 jpeterson976 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maufcost @FrenjaminBanklin @jpeterson976