Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic to dismiss spinner after prompt closes #1914

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Added logic to dismiss spinner after prompt closes #1914

merged 1 commit into from
Oct 26, 2021

Conversation

maufcost
Copy link
Contributor

Fixes #1913

jpeterson976
jpeterson976 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Spinner doesn't show up when cancelling a multi-delete anymore for me.

@FrenjaminBanklin FrenjaminBanklin added the hacktoberfest Viable to be worked on for Hacktoberfest label Oct 5, 2021
FrenjaminBanklin
FrenjaminBanklin approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet. Solves the problem.

@FrenjaminBanklin FrenjaminBanklin merged commit 834787c into ucfopen:dev/26-neon-apatite Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeterson976 jpeterson976 jpeterson976 approved these changes

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

Assignees
No one assigned
Labels
hacktoberfest Viable to be worked on for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maufcost @FrenjaminBanklin @jpeterson976