Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1575 omit already shared #1918

Conversation

walid-i
Copy link
Contributor

@walid-i walid-i commented Oct 5, 2021

When sharing omits users that already have access

@FrenjaminBanklin FrenjaminBanklin added the hacktoberfest Viable to be worked on for Hacktoberfest label Oct 5, 2021
@walid-i walid-i changed the base branch from master to dev/26-neon-apatite October 7, 2021 14:00
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functions well, there are just a few minor nits to pick as far as cleaning up the code and making sure the tests are actually testing.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just remove the large commented block from packages/app/obojobo-repository/shared/components/people-search-dialog.jsx and it should be all set.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/26-neon-apatite to dev/28-jadeite March 3, 2022 20:26
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep our backlog under control, but we thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@RachelDau RachelDau changed the base branch from dev/28-jadeite to dev/30-howlite February 15, 2023 15:21
@stale stale bot removed the stale label Feb 15, 2023
@RachelDau RachelDau force-pushed the issue/1575-omit-already-shared branch from d30da5a to 048816c Compare February 15, 2023 18:49
@RachelDau RachelDau self-assigned this Feb 15, 2023
@RachelDau
Copy link
Contributor

RachelDau commented Feb 15, 2023

I merged in dev 30 except four style files which have lint errors. These lint errors appear to be already in dev30, so if I alter the files in order to commit them then they will continue to show up on this PR diff. I was not sure if that was ideal so I didn't not commit those files yet. They show up in the diff right now without the dev30 merge updates.

@RachelDau RachelDau force-pushed the issue/1575-omit-already-shared branch from 9155352 to 048816c Compare March 2, 2023 16:34
@RachelDau
Copy link
Contributor

merged with Dev 30 and lint style updates made in 4 files. These four files more-info-box.scss, objective-list-view.scss, search.scss, and objective-item.scss are seperate from this PR, but needed their styles to be updated to be merged in. I also removed the commented code requested to be removed above.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code isn't building to test, see below.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/30-howlite to dev/31-taconite March 21, 2023 15:42
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is working properly and performing as advertised.

@FrenjaminBanklin FrenjaminBanklin merged commit 2ac6106 into ucfopen:dev/31-taconite Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Viable to be worked on for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants