Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added justified alignment option #1940

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Added justified alignment option #1940

merged 3 commits into from
Jan 28, 2022

Conversation

maufcost
Copy link
Contributor

@maufcost maufcost commented Dec 2, 2021 •
edited
Loading

Fixes #1926

@maufcost maufcost changed the title Added initial logic for new text alignment option Added justified alignment option Dec 2, 2021
@maufcost maufcost marked this pull request as ready for review December 7, 2021 16:51
@maufcost maufcost requested review from a team, deundrewilliams and SJJacques and removed request for a team December 7, 2021 16:51
deundrewilliams
deundrewilliams reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@deundrewilliams deundrewilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in each browser, the justification button in the menu works for all, but it looks like the keystroke (cmd+shift+J) only works in Chrome and Safari

@maufcost
Copy link
Contributor Author

maufcost commented Dec 7, 2021

Thanks for pointing this out. I will investigate.

@SJJacques
Copy link
Contributor

The button and command both work for me on all browsers. It only justifies on Chrome; Firefox and Safari change alignment but there's no difference between left align and justify.

@maufcost
Copy link
Contributor Author

Everything seems to be working now on all major browsers (Chrome, Safari, and Firefox). The issue before seemed to be a white-space bug exclusively on Firefox that developers had faced before. It's fixed now. Let me know if anyone comes across any issues.

@SJJacques
Copy link
Contributor

Tested it out and everything seems to work.

deundrewilliams
deundrewilliams previously approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@deundrewilliams deundrewilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and everything (menu button and keystroke) works in each browser

jpeterson976
jpeterson976 previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the button and the command work in all three browsers for me as well. LGTM

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/26-neon-apatite to dev/27-pyrite January 5, 2022 16:46
@FrenjaminBanklin FrenjaminBanklin dismissed stale reviews from jpeterson976 and deundrewilliams January 5, 2022 16:46

The base branch was changed.

jpeterson976
jpeterson976 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after base change

SJJacques
SJJacques approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@SJJacques SJJacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also approving after base change.

@FrenjaminBanklin FrenjaminBanklin merged commit 8944a18 into ucfopen:dev/27-pyrite Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeterson976 jpeterson976 jpeterson976 approved these changes

@SJJacques SJJacques SJJacques approved these changes

@deundrewilliams deundrewilliams deundrewilliams left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maufcost @SJJacques @deundrewilliams @jpeterson976 @FrenjaminBanklin