Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional read-only mode for copied modules and optional update auto-sync for read-only copies. #2074

Conversation

FrenjaminBanklin
Copy link
Contributor

Closes #2005.

It turns out tracking copies isn't a problem because metadata has always been generated for that purpose.

Adds support for optionally making copies read-only with the ability to automatically synchronize updates from the original. This will allow users to have copies of modules that they can see assessment statistics for while also allowing them to keep their copy up-to-date with any content changes.

…ons before rendering copy/preview buttons in a module's public page. Adds 'normal' and 'read-only' copy options to a module's public page. Replaces 'edit' button with 'synchronize' button in module dashboard for read-only modules. Adds a new dialog and relevant backend logic to automatically synchronize a read-only copied module with its original if any changes have been made.
@RachelDau RachelDau self-requested a review April 19, 2023 12:39
Copy link
Contributor

@RachelDau RachelDau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working when testing. I looked through the code and it seemed good too, but there is alot of code, and I didn't quite understand everything so another reviewer should also review to be sure.

One thing I noticed is the synchronize button appears on a copied module read-only when you click on it from the dashboard, however if you select more and open up the full module options it no longer appears. I do not know if it should appear in module options or how hard it would be to add.

@FrenjaminBanklin
Copy link
Contributor Author

Good catch. Should have a button in the expanded options menu, too. Will fix.

@RachelDau RachelDau self-requested a review May 2, 2023 12:59
RachelDau
RachelDau previously approved these changes May 2, 2023
Copy link
Contributor

@RachelDau RachelDau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@FrenjaminBanklin FrenjaminBanklin marked this pull request as draft May 22, 2023 13:11
@FrenjaminBanklin
Copy link
Contributor Author

It just occurred to me that there's a 'Make a Copy' option in the document editor. There should probably also be a 'Make a Read-Only Copy' option adjacent to that one.

Setting this back to a draft until I can do that.

@mbusch3 mbusch3 self-assigned this Jun 22, 2023
@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/31-taconite to dev/32-pigeonite July 21, 2023 17:04
@FrenjaminBanklin FrenjaminBanklin dismissed RachelDau’s stale review July 21, 2023 17:04

The base branch was changed.

@FrenjaminBanklin FrenjaminBanklin marked this pull request as ready for review July 21, 2023 20:32
Viggie1
Viggie1 previously approved these changes Jul 31, 2023
Copy link

@Viggie1 Viggie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working on my end, LGTM.

@FrenjaminBanklin FrenjaminBanklin merged commit 7112d66 into ucfopen:dev/32-pigeonite Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants