Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure there is a minimum of 3 points along each edge of the srf #251

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Ensure there is a minimum of 3 points along each edge of the srf #251

merged 1 commit into from
Sep 12, 2021

Conversation

jpa198
Copy link
Contributor

@jpa198 jpa198 commented Sep 12, 2021

If the length was less than 1 km there were 0 points, resulting in an error from the Path

@jpa198
Ensure there is a minimum of 3 points along each edge of the srf
3d4e67c 
If the length was less than 1 km there were 0 points, resulting in an error from the Path
jasonmotha
jasonmotha approved these changes Sep 12, 2021
View reviewed changes
Copy link
Contributor

@jasonmotha jasonmotha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, could this be influencing my bus error? -- maybe not but still interesting to consider.

shot0829
shot0829 approved these changes Sep 12, 2021
View reviewed changes
Copy link
Contributor

@shot0829 shot0829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ha , tiny sub-faults giving us more trouble.

@jpa198
Copy link
Contributor Author

jpa198 commented Sep 12, 2021

Oooh, could this be influencing my bus error? -- maybe not but still interesting to consider.

It shouldn't be, python should just raise the exception and call it a day

@jpa198 jpa198 merged commit 368e6f4 into master Sep 12, 2021
@jpa198 jpa198 deleted the vm_bounds_check_bug branch September 12, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shot0829 shot0829 shot0829 approved these changes

@jasonmotha jasonmotha jasonmotha approved these changes

@mrldupuis mrldupuis Awaiting requested review from mrldupuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpa198 @shot0829 @jasonmotha