Plot srf map bug #253
Merged
Plot srf map bug #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor76525
previously approved these changes
Sep 20, 2021
jpa198
reviewed
Sep 20, 2021
jasonmotha
suggested changes
Sep 21, 2021
viktor76525
approved these changes
Sep 21, 2021
jasonmotha
approved these changes
Sep 21, 2021
jpa198
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alphashape needs alpha parameter to be set (alpha=0 is a convex hull), but often we need a concave-hull. The question is how to determine the alpha parameter to give the best fit. Viktor originally found alpha=600 worked ok for SRF, but sometimes it doesn't return a legit Polygon object that will ensure the subsequent code works.
This fix will, hopefully, find a reasonably good alpha value without impacting the performance too much.