Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single frequency bandpass to bwfilter #259

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Add single frequency bandpass to bwfilter #259

merged 3 commits into from
Nov 16, 2021

Conversation

jpa198
Copy link
Contributor

@jpa198 jpa198 commented Nov 15, 2021

No description provided.

Copy link
Member

@sungeunbae sungeunbae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a request change - just an opinion

Bandstop is a freebie, so why not
Explicit lowpass doesn't do much except make it clear that it's for lowpass, and helps enumerate the options for btype
Any other band will result in an exception being thrown by butter
Also add more documentation to the function help
@sungeunbae sungeunbae self-requested a review November 16, 2021 01:48
@sungeunbae sungeunbae merged commit d8ac859 into master Nov 16, 2021
@jpa198 jpa198 deleted the add_bandpass branch November 16, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants