Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site specific bb #264

Merged
merged 6 commits into from
May 24, 2022
Merged

Site specific bb #264

merged 6 commits into from
May 24, 2022

Conversation

jpa198
Copy link
Contributor

@jpa198 jpa198 commented Feb 1, 2022

No description provided.

jpa198 and others added 4 commits October 22, 2021 15:51
Includes a stand alone script, currently set up for debugging, the Tcl scripts required for running OpenSees and modifications to timeseries.py for functions used in the deconvolution.
@jasonmotha
Copy link
Contributor

In general, looks good to me. What's the best way to get a quick explanation of what's happening here?

@jpa198
Copy link
Contributor Author

jpa198 commented Feb 1, 2022

In general, looks good to me. What's the best way to get a quick explanation of what's happening here?

Not even up for review yet, just wanted to get the diff...

The short of it is: The correct transfer function was included in Felipes source code for running site specific, and as part of that I chose to fix the function here (previous had no references) instead of adding it into workflow.
Not sure if it'll be useful outside site specific, but we can refactor later if it becomes an issue for some reason.

Added the site specific entry to the platform config so we can have an organised way of storing the data

@jpa198 jpa198 requested review from chrisdelat, jasonmotha and sungeunbae and removed request for chrisdelat May 4, 2022 21:14
@jpa198
Copy link
Contributor Author

jpa198 commented May 4, 2022

In general, looks good to me. What's the best way to get a quick explanation of what's happening here?

These are the changes I've made to qcore to support the inclusion of site specific amplification through Chris/Felipes OpenSees work.
The transfer function details are as taken from the code Felipe provided for integration, and instead of add it somewhere else, I fixed the current function instead.
As to how it works, that's a question for Chris/Felipe, however I have used this as the transfer function for site specific runs that have been verified by Felipe, so I believe it is correct.

jasonmotha
jasonmotha previously approved these changes May 5, 2022
sungeunbae
sungeunbae previously approved these changes May 9, 2022
@jpa198 jpa198 requested a review from joelridden May 19, 2022 21:50
@jpa198 jpa198 merged commit 004c718 into master May 24, 2022
@jpa198 jpa198 deleted the site_specific_BB branch May 24, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants