Archive Structure #283
Merged
Archive Structure #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpa198
reviewed
Mar 15, 2023
qcore/archive_structure.py
Outdated
Comment on lines
7
to
9
| def get_fault_from_realisation(realisation: str): | ||
| """Gets the fault name from the realisation name""" | ||
| return realisation.rsplit("_REL", 1)[0] |
There was a problem hiding this comment.
If this function is already in simulation structure, it should be imported instead of re-written. To make sure they do the same thing
jpa198
previously approved these changes
Mar 15, 2023
sungeunbae
previously approved these changes
Mar 15, 2023
jpa198
previously approved these changes
Mar 17, 2023
jpa198
approved these changes
Mar 20, 2023
sungeunbae
reviewed
Mar 20, 2023
sungeunbae
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functions to support new archive structure