Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simulation_hazard.py #3

Open
wants to merge 1 commit into
base: hazard_example
Choose a base branch
from
Open

Conversation

Mor-Abs
Copy link

@Mor-Abs Mor-Abs commented Feb 5, 2025

The following line failed when working with versions 20.4 and 20.5.
else:
assert np.all(cur_stations == cur_im_df.index)
assert np.all(cur_IMs == cur_im_df.columns[1:])

To address the issue that not all CSV files might share the same stations (or IMs), I modified the code so that it includes all data into cur_im_array and removes stations and IMs with missing data.

The following line failed when working with versions 20.4 and 20.5. 
            else:
                assert np.all(cur_stations == cur_im_df.index)
                assert np.all(cur_IMs == cur_im_df.columns[1:])


To address the issue that not all CSV files might share the same stations (or IMs), I modified the code so that it includes all data into cur_im_array and removes stations and IMs with missing data.
@lispandfound lispandfound self-requested a review February 13, 2025 02:58
Copy link

@lispandfound lispandfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me.

@lispandfound
Copy link

@claudio525 maybe take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants