Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs untested account fixes etc #407

Merged
merged 6 commits into from
Oct 12, 2021
Merged

cs untested account fixes etc #407

merged 6 commits into from
Oct 12, 2021

Conversation

jasonmotha
Copy link
Contributor

@jasonmotha jasonmotha commented Oct 8, 2021

Description

Checks all platform accounts for jobs before marking them as missing from queue. And a --no-queue-monitor flag if you want to run run_cs without queue-monitor thread running.

ucgmsim/qcore#254 depends on this PR (needs to be merged at the same time)

Changes were tested in cs_fixes branch and then the changes applied to master.

Copy link
Contributor

@shot0829 shot0829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
But I'm curious about the use case of no-queue-monitor.
Were you trying to run the same install/batch of simulations using different account to speed it up?
Did you have different task_config to prevent two daemons submitting jobs for the same event?

@jasonmotha
Copy link
Contributor Author

Good question. Yeah, was using it to submit jobs on both queues. Mainly to level the CH use on both accounts to keep our fairshare steady. Because I was limiting n_jobs, both run_cybershake threads didn't get around to submitting jobs at the same time. Most of the time when I'd use something like this, I'd dump jobs into the queue and then kill the process.
If I were to leave two copies running over a longer period, separate config files would be a better option!

Looks good. But I'm curious about the use case of no-queue-monitor. Were you trying to run the same install/batch of simulations using different account to speed it up? Did you have different task_config to prevent two daemons submitting jobs for the same event?

@jasonmotha
Copy link
Contributor Author

@sungeunbae I'll merge this now as it's currently out of sync with qcore, but if you have any other change requests I can open another PR?

@jasonmotha jasonmotha merged commit 647f3db into master Oct 12, 2021
@jasonmotha jasonmotha deleted the cs_fixes_master branch October 12, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants