Scientific Registry and Cleanup #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispandfound
requested review from
sungeunbae,
joelridden,
claudio525 and
AndrewRidden-Harper
joelridden
reviewed
Jan 20, 2025
workflow/scripts/check_srf.py
Outdated
| @@ -24,6 +24,12 @@ def check_srf( | |||
| Path, typer.Argument(help="The path to the realisation for the SRF.") | |||
| ], | |||
| srf_ffp: Annotated[Path, typer.Argument(help="The path to the SRF file to check.")], | |||
| velocity_model_path: Annotated[ | |||
There was a problem hiding this comment.
Just a potential rename of registry_velocity_model_path to remove some potential confusion. Along with all the other ones
claudio525
approved these changes
Jan 27, 2025
joelridden
approved these changes
Jan 28, 2025
AndrewRidden-Harper
approved these changes
Jan 28, 2025
claudio525
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the scientific registry in ucgmsim/qcore#341 with the workflow. It replaces the old scientific defaults with defaults sourced from the registry. It also takes the opportunity to remove and cleanup the directory structure.