Fix(realisation-to-srf): Typo in plane length #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispandfound
requested review from
sungeunbae,
joelridden,
claudio525 and
AndrewRidden-Harper
joelridden
approved these changes
Mar 3, 2025
AndrewRidden-Harper
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but important PR. I added a change to fix SRF generation but introduced a bug that results in miscalculating the number of SRF points in the fault. Shouldn't cause a problem for existing researcher SRFs because no one to my knowledge is using more than one plane per fault (except me generating alpine ruptures today).