-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
753 inconsistet fonts and spacing on loop #761
753 inconsistet fonts and spacing on loop #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that the Loop SCSS needs to be compressed separately. I wasn't able to run Gulp, so I made 'compressed' changes manually. I also fixed the difference in font-size and line-height, and added a |
This is looking a lot better. I see the text is constrained now and the line height looks better. I still see a couple of issues though.
Maybe if we address the first issue in this PR, we can open a new PR for the second. Otherwise, we could address them both here. I don't have a strong preference. |
It seems these new rules do not apply on the news page type. I'll make new rules to include those as well. |
Nice, this looks good to go! |
Fixes #753.
Fixes #754.
Changes in this request
p
rule to the general.block-paragraph
.z-index
to the left sidebar so that its content doesn't get visually mixed with the footer.