-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide SITS Grade push settings for users with no permission #25
Conversation
Thanks |
I think no need to do step 1, because I have many changes to the codes for my current tickets. I will do the coding standards fix. |
@nbozhkov-ucl I meant please just make sure your code changes are meeting the coding standards. |
Thanks Alex. I know the change I made is pretty simple but helps me start to learn Moodle coding. You can incorporate in your branch and close my pull request when needed. |
Yep I meant 1 specifically for the lines you were changing, not about fixing the wider codebase errors. |
Code is deployed to 42-clc and all coding standards errors/warnings introduced by me fixed. |
Tested - 👍 Code - looks good to me, thanks for fixing coding standards 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.