fixed event images not showing #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caz07
commented
Oct 27, 2023
caz07
commented
- reformatted drive file links to direct image links
- many images on the official website still won't work due to invalid URLs or bad sharing permissions
ajtadeo
requested changes
Nov 2, 2023
There was a problem hiding this comment.
this might be a frontend bug, but the preview image for adding new events doesn't reformat the drive links correctly. it might be good to have a default image when opening the add event panel, otherwise its just a grey box. after saving the event the image displays correctly when opening the update event panel.
other than that, google drive links and image permalinks display correctly on the event feed!
|
@caz07 bumping this. Let's aim to resolve and merge this fix before the start of Winter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.