Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error removals #738

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Error removals #738

merged 4 commits into from
Nov 26, 2024
+7 −6

Conversation

smalex-z
Copy link
Contributor

@smalex-z smalex-z commented Nov 26, 2024 •
edited
Loading

Describe your changes

Fixed a bunch of little warnings/errors and minor updates, including

  • Key Error on Officer cards,
  • Abrupt fontsize transitions between screensizes
  • Updating Dev Team Description

Issue ticket number and link

N/A

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@smalex-z smalex-z self-assigned this Nov 26, 2024
yeadamk
yeadamk approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@yeadamk yeadamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@smalex-z smalex-z merged commit 1e7c4da into main Nov 26, 2024
8 checks passed
@smalex-z smalex-z deleted the error-removals branch November 26, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeadamk yeadamk yeadamk approved these changes

Assignees

@smalex-z smalex-z

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smalex-z @yeadamk