Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to v2.0.2 #9

Merged
merged 3 commits into from
Jun 17, 2023
Merged

update to v2.0.2 #9

merged 3 commits into from
Jun 17, 2023

Conversation

sorelfitzgibbon
Copy link
Collaborator

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Hub Auto Build Rules

  • I have created automated build rules following this page and I have not manually pushed this Docker image to the blcdsdockerregistry on Docker Hub.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

My command:

/hot/user/sfitzgibbon/git/docker-MuSE/runTestMuse.sh

Description

Closes #8

Updated to MuSE v2.0.2

@sorelfitzgibbon
Copy link
Collaborator Author

Should I test this on the large input BAMs before making the release, or should I test it within call-sSNV after updating to this release?

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about the version encoding in the Dockerfile:

Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! I'll leave it for Mao's final review

Copy link
Collaborator

@maotian06 maotian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

Copy link

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few things to add.

L26 - associate this repo with the GitHub package and update the label.

https://github.com/uclahs-cds/template-docker/blob/736215a19cc5e87a29121f4f4b9abbfb956da852/Dockerfile#L25

Also, not for this PR, it would be nice to update the PR template to use github packages instead of dockerhub. Lastly, consider using /hot/software/image for the standardized dev/release structure.

@sorelfitzgibbon sorelfitzgibbon merged commit 43cd6a6 into main Jun 17, 2023
@sorelfitzgibbon sorelfitzgibbon deleted the sfitz-update-to-v2.0.2 branch June 18, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to version 2.0.2
4 participants