Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package manual file #36

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Remove package manual file #36

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25ed64d
Delete unnecessary package manual file
jsahrmann Aug 28, 2023
a10cd28
Update DESCRIPTION and NEWS
jsahrmann Aug 28, 2023
0aa07a0
Add self to NEWS
jsahrmann Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: VennDiagram
Version: 1.8.0
Type: Package
Title: Generate High-Resolution Venn and Euler Plots
Date: 2023-08-23
Date: 2023-08-28
Author: Hanbo Chen
Maintainer: Paul Boutros <pboutros@mednet.ucla.edu>
Imports:
Expand Down
2 changes: 1 addition & 1 deletion NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VennDiagram 1.8.0 2023-08-23 (Stefan Eng, Dan Knight)
VennDiagram 1.8.0 2023-08-28 (Stefan Eng, Dan Knight)
---------------------------------------------------------------------------------------------------
Copy link
Contributor

@dan-knight dan-knight Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself! Also, you can add yourself as a contributor in DESCRIPTION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package doesn't have an Authors@R field in DESCRIPTION where I could add myself, and apparently Maintainer can only be a single person: "The mandatory ‘Maintainer’ field should give a single name followed by a valid (RFC 2822) email address in angle brackets" (Writing R Extensions). I can add the Authors@R field or just stop with the addition to NEWS. I probably don't need to be considered a contributor after just deleting a file, so I'd be fine with just that.

MINOR UPDATES
* Implemented S3 print/plot methods for VennDiagram class
Expand Down
21 changes: 0 additions & 21 deletions man/VennDiagram-package.Rd
View file
Open in desktop

This file was deleted.

Loading