Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow patterns in file paths #51

Merged
merged 11 commits into from
Jan 5, 2024
Merged

Allow patterns in file paths #51

merged 11 commits into from
Jan 5, 2024

Conversation

yashpatel6
Copy link
Contributor

Description

Closes #49

Adding support for patterns in file paths

Tests

Tested with pipeline-demo-pipeline

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

Copy link
Member

@zhuchcn zhuchcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So users can specify the expected file as /path/to/dir/*.bam?

@sorelfitzgibbon
Copy link

I think it's more to avoid having to keep updating the pipeline version number in the assertions. I will try to test this with call-sSNV later today.

@yashpatel6
Copy link
Contributor Author

Right, to basically make the file specification more generalize-able without having to update tests with every pipeline version update or minor tool update, etc

nftest/common.py Outdated Show resolved Hide resolved
nftest/common.py Outdated Show resolved Hide resolved
@sorelfitzgibbon
Copy link

Just tested this branch in pipeline-call-sSNV. Wild card paths worked.
uclahs-cds/pipeline-call-sSNV#248

Copy link
Member

@zhuchcn zhuchcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too!

Sorry I thought this was a new PR..

nftest/NFTestAssert.py Outdated Show resolved Hide resolved
test/unit/test_NFTestAssert.py Outdated Show resolved Hide resolved
@yashpatel6
Copy link
Contributor Author

@aholmes anything else to add here?

@aholmes
Copy link
Member

aholmes commented Jan 5, 2024

@aholmes anything else to add here?

Nope, looks good!

@yashpatel6 yashpatel6 merged commit 39f1119 into main Jan 5, 2024
1 check passed
@yashpatel6 yashpatel6 deleted the yashpatel-allow-wildcards branch January 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow wildcards in assertion paths
5 participants