Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails & ruby #158

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Update rails & ruby #158

merged 7 commits into from
Nov 16, 2022

Conversation

bsp3ars
Copy link
Contributor

@bsp3ars bsp3ars commented Oct 28, 2022

Resolves #157

Here is the current status of the branch:

  • Ruby and Rails have been updated to 3.0.4p208 and 6.0.6 respectively
  • The code works in development mode
  • One feature test is kinda wonky, specifically I couldn't get it to wait long enough to find an id after a page change (spec/features/create_admin_spec.rb lines 36-38)
  • The capistrano deploy to QA is failing due to ArgumentError: Missing secret_key_base for 'production' environment, set this string with rails credentials:edit

Recent Troubleshooting Steps:

  1. I added the secret_key_base to the .env.production.local on QA but it didn't resolve the issue
  2. Started to look into the Rails 6 changes regarding how secret_key_base is stored and referenced

Other things of note:

@crowesn crowesn force-pushed the update-rails branch 5 times, most recently from c3d80cc to 949133b Compare November 9, 2022 20:59
@crowesn
Copy link
Contributor

crowesn commented Nov 10, 2022

  • Corrected .env filename in Capistrano config
  • add rbenv config to :production deploy config
  • Created new secret key

@crowesn crowesn changed the title (WIP) Update rails & ruby Update rails & ruby Nov 10, 2022
@crowesn
Copy link
Contributor

crowesn commented Nov 10, 2022

@lisa3711 @scherztc
this should be ready to go.

@scherztc
Copy link
Contributor

Coveralls : Coverage report generated for RSpec to /Users/scherztc/Workspaces/aaec/coverage. 641 / 697 LOC (91.97%) covered.

@scherztc
Copy link
Contributor

scherztc commented Nov 15, 2022

The main thing that wasn't well documented and therefore unable to test:

  1. How do I login as the admin user to see all of the publications?
  2. Why Webpacker?

@scherztc
Copy link
Contributor

We ran the test suite locally, read through the code and made comments, and spun up the application, reviewed circleci, and clicked through the available features.

We still need to do a test deploy with Capistrano.

Copy link
Contributor

@scherztc scherztc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran the test suite locally, read through the code and made comments, and spun up the application, reviewed circleci, and clicked through the available features.

We still need to do a test deploy with Capistrano.

spec/spec_helper.rb Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@scherztc scherztc merged commit 336eb57 into qa Nov 16, 2022
@scherztc scherztc deleted the update-rails branch November 16, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to ruby 3.0.x and rails 6.0.x
4 participants