Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selenium-webdriver to version 4.11.0 or higher #173

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Janell-Huyck
Copy link
Contributor

Update selenium-webdriver to version 4.11.0 or higher
Pull Request Description:
This PR updates the selenium-webdriver gem in the test group to version 4.11.0 or higher. This change aims to take advantage of the latest features and improvements offered by the newer version of selenium-webdriver.

Fixes #172

Changes Made:
Updated the Gemfile to specify that the selenium-webdriver gem should be version 4.11.0 or higher.

Old Gemfile

group :test do
  gem 'capybara', '>= 2.15'
  gem 'capybara-selenium', '~> 0.0.6'
  gem 'selenium-webdriver'
  gem 'webdrivers'
end

New Gemfile

group :test do
  gem 'capybara', '>= 2.15'
  gem 'capybara-selenium', '~> 0.0.6'
  gem 'selenium-webdriver', '>=4.11.0'
end

I initially ran bundle update, and upon completing that update, the tests were able to run again without error. When I ran bundle update, I got this message:
I ran bundle update, and got the following message:

Post-install message from webdrivers:
Webdrivers gem update options
*****************************

Selenium itself now manages drivers by default: https://www.selenium.dev/documentation/selenium_manager
* If you are using Ruby 3+ — please update to Selenium 4.11+ and stop requiring this gem
* If you are using Ruby 2.6+ and Selenium 4.0+ — this version will work for now
* If you use Ruby < 2.6 or Selenium 3, a 6.0 version of this gem with additional support is planned

By directly requiring a version of selenium-webdriver >= 4.11, I was able to remove the "webdrivers" gem. Running "bundle install" gives no errors, and the tests still complete without error. These changes should make us more resilient to future dependency updates.

@scherztc scherztc self-assigned this Sep 6, 2023
@scherztc scherztc merged commit 8cb51f3 into qa Sep 6, 2023
2 checks passed
@scherztc scherztc deleted the 172-fix-chrome-test-failure branch September 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to run on latest Chrome version
2 participants