150 resolved dynamic-render-path-vulnerability #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
150-dynamic-render-path-vulnerability
branch
from
887cd32
to
ed56f98
Compare
crowesn
approved these changes
Sep 13, 2023
Janell-Huyck
force-pushed
the
150-dynamic-render-path-vulnerability
branch
from
ea237d0
to
4e16c6f
Compare
|
Is this PR ready for @crowesn's re-review? |
|
I was holding off on this until we decided how to handle the webpack issue encountered during deploy since I wasn’t sure if we were going to be doing any reverting.. Is it okay to merge more PRs?
|
|
After Thomas's webpacker PR is merged, I will rebase if necessary and then this should be ready for re-review and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Fix Dynamic Render Path Vulnerability in PagesController
This PR addresses a security concern raised by Brakeman concerning dynamic render paths in the PagesController. Specifically, Brakeman flagged the use of params[:page] directly in a render call as a potential risk.
Changes:
Refactored PagesController to use a whitelist approach for page rendering.
Added a type check to ensure that params[:page] is a string.
Added test for the whitelist to ensure that future developers do not add a page without adding it to the whitelist.